WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] make c/s 21089 work again with c/s 21092

To: <waldi@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] make c/s 21089 work again with c/s 21092
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Wed, 14 Apr 2010 08:41:52 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 14 Apr 2010 00:42:39 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Bastian Blank  04/14/10 9:16 AM >>>
>On Tue, Apr 13, 2010 at 02:36:55PM +0100, Jan Beulich wrote:
>> +    spin_lock_irqsave(&desc->lock, flags);
>
>Why do you lock here? The whole thing is racy anyway and this should only
>battle against concurent registrations from dom0.

It seems cleaner to do proper locking here, even though I too think it's not 
strictly needed.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>