WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] radeon in dom0/ivtv in domU: irq 16 nobody cared

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: Re: [Xen-devel] radeon in dom0/ivtv in domU: irq 16 nobody cared
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Tue, 13 Apr 2010 12:21:41 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Mark Hurenkamp <mark.hurenkamp@xxxxxxxxx>
Delivery-date: Tue, 13 Apr 2010 12:22:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100413191005.GB9173@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AEB83A1C-247E-4B52-AB14-977664379FDE@xxxxxxxxx> <20100408001916.GA10840@xxxxxxxxxxxxxxxxxxx> <20100408173700.GB26343@xxxxxxxxxxxxxxxxxxx> <4BBE2451.7090600@xxxxxxxx> <20100413131804.GB16475@xxxxxxxxxxxxxxxxxxx> <4BC4B84D.1040505@xxxxxxxx> <20100413191005.GB9173@xxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.4
On 04/13/2010 12:10 PM, Konrad Rzeszutek Wilk wrote:
>> Does the kernel get to know about the passed-through irqs?  I was
>> thinking that at pass-through time it would install the handler in dom0
>> on the irq (and all other domains sharing the irq), and then the handler
>> could do that hypercall and return IRQ_HANDLED / IRQ_NONE accordingly.
>>     
> That was my other thought. But that means that the handler has to
> do a hypercall - which I thought is a bit too heavy handed considering we 
> only need
> to know whether it is shared only once.

It could just return IRQ_HANDLED unconditionally, without doing the
hypercall.  Remember you also need it in the domU and any other domU
using the same GSI.

>  The fake irq handler gets
> disabled if the domain is turned off/pci hotplug removed.
>   

Yep.

> Currently the fake IRQ handler is installed on the IRQ that is requested
> by the guest. So if the IRQ is not shared in Dom0, it still gets
> inserted in (and it won't receive any interrupts since that IRQ line is
> not shared with the domain 0).
>   

Just for clarity's sake, you mean GSI for each instance of IRQ here, right?

>> Hrm.  You could instrument Xen to see who's masking the interrupt.
>>     
> <nods>Right now I am, digging through code to figure out how to make this
> happen without inserting to much code in the handler which would have
> slowed the machine to a crawl.
>   

I was thinking of something very dumb and ad-hoc, like putting an
explicit "if (gsi == X && masking) print something".

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel