xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] tmem: typo causes incorrect return on out-of-memory

from [Dan Magenheimer]

[Permanent Link][Original]

To:	"Xen-Devel (xen-devel@xxxxxxxxxxxxxxxxxxx)" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [PATCH] tmem: typo causes incorrect return on out-of-memory
From:	Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
Date:	Tue, 9 Mar 2010 07:59:27 -0800 (PST)
Delivery-date:	Tue, 09 Mar 2010 08:03:47 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

This classic typo in tmem would result in a false positive
report on a tmem "put" operation if a (unfragmented) page
of memory is completely unavailable.

Signed-off-by: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>

diff -r b8d2a4134a68 xen/common/tmem.c
--- a/xen/common/tmem.c Wed Mar 03 17:41:58 2010 +0000
+++ b/xen/common/tmem.c Tue Mar 09 08:53:12 2010 -0700
@@ -1308,7 +1308,7 @@ copy_uncompressed:
 copy_uncompressed:
     if ( ( pgp->pfp = tmem_page_alloc(pool) ) == NULL )
     {
-        ret == -ENOMEM;
+        ret = -ENOMEM;
         goto delete_and_free;
     }
     /* tmh_copy_from_client properly handles len==0 (TMEM_NEW_PAGE) */

tmem-typo.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] tmem: typo causes incorrect return on out-of-memory, Dan Magenheimer <=

Previous by Date:	Re: [Xen-devel] A clocksource question, Konrad Rzeszutek Wilk
Next by Date:	[Xen-devel] [PATCH SERIES v2] enhanced PV on Xen HVM, Stefano Stabellini
Previous by Thread:	[Xen-devel] [GIT PULL] pv/pciback-2.6.32, Konrad Rzeszutek Wilk
Next by Thread:	[Xen-devel] [PATCH SERIES v2] enhanced PV on Xen HVM, Stefano Stabellini
Indexes:	[Date] [Thread] [Top] [All Lists]