WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 5/7] xen: Make event channel work with PV extensi

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 5/7] xen: Make event channel work with PV extension of HVM
From: Sheng Yang <sheng@xxxxxxxxxxxxxxx>
Date: Thu, 4 Mar 2010 13:37:26 +0800
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Ian Pratt <Ian.Pratt@xxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Wed, 03 Mar 2010 21:36:56 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B8C6C0D.3070005@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Intel Opensource Technology Center
References: <1267436315-24486-1-git-send-email-sheng@xxxxxxxxxxxxxxx> <1267436315-24486-6-git-send-email-sheng@xxxxxxxxxxxxxxx> <4B8C6C0D.3070005@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.12.2 (Linux/2.6.31-19-generic; KDE/4.3.2; x86_64; ; )
On Tuesday 02 March 2010 09:38:21 Jeremy Fitzhardinge wrote:
> On 03/01/2010 01:38 AM, Sheng Yang wrote:
> > +
> > +           x86_platform.calibrate_tsc = xen_tsc_khz;
> > +           x86_platform.get_wallclock = xen_get_wallclock;
> > +           x86_platform.set_wallclock = xen_set_wallclock;
> > +
> > +           pv_apic_ops = xen_apic_ops;
> > +#ifdef CONFIG_X86_LOCAL_APIC
> > +           /*
> > +            * set up the basic apic ops.
> > +            */
> > +           set_xen_basic_apic_ops();
> > +           apic->write = xen_hvm_pv_evtchn_apic_write;
> 
> I'd just change the xen_apic_write to remove the WARN_ON, since you
> don't seem to care about it either.

So which code base I should make these patches against? We expect the patchset 
can be accepted in the Linux upstream soon after you pick it up.
> 
> >
> > -   exit_idle();
> > -   irq_enter();
> > +   /*
> > +    * If is PV featured HVM, these have already been done
> > +    */
> > +   if (likely(!xen_hvm_pv_evtchn_enabled())) {
> > +           exit_idle();
> > +           irq_enter();
> > +   }
> 
> In that case, rather than putting this conditional in the hot path, make
> an inner __xen_evtchn_do_upcall which is wrapped by the PV and HVM
> variants which do the appropriate things.  (And drop the pt_regs arg, I
> think.)

Seems we still need pt_regs to for handle_irq()?

-- 
regards
Yang, Sheng

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>