WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] [PVOPS] fix gntdev on PAE

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [PVOPS] fix gntdev on PAE
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Wed, 10 Feb 2010 12:19:52 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Wed, 10 Feb 2010 04:17:29 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B71DA53.1080404@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.1002011504070.24837@kaball-desktop> <alpine.DEB.2.00.1002011544380.24837@kaball-desktop> <4B71DA53.1080404@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Tue, 9 Feb 2010, Jeremy Fitzhardinge wrote:
> On 02/01/2010 07:46 AM, Stefano Stabellini wrote:
> > On Mon, 1 Feb 2010, Stefano Stabellini wrote:
> >    
> >> Hi all,
> >> this small patch fixes gntdev on Linux pvops kernels:
> >> gnttab_set_map_op and gnttab_set_unmap_op shouldn't take unsigned long
> >> as parameters for machine addresses because they are not big enough on
> >> PAE systems.
> >> This patch fixes the issue using phys_addr_t instead and enables
> >> XEN_GNTDEV compilation again.
> >>
> >>
> >> Signed-off-by: Stefano Stabellini<stefano.stabellini@xxxxxxxxxxxxx>
> >>
> >>      
> > BTW gntdev is used by qemu to provide the console backend to pv guests.
> >    
> 
> Is that recent?  Console had been working before hadn't it?
> 
> The gntdev problems I saw were more locking related than anything to do 
> with PAE.  Did you try testing with lock debugging enabled?
> 

Yes, I don't have any problem with locking in gntdev on my testbox.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>