WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] HVM vcpu hotplug: Fix acpi method NTFY bug

To: "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] HVM vcpu hotplug: Fix acpi method NTFY bug
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 01 Feb 2010 12:40:09 +0000
Cc: "Zheng, Shaohui" <shaohui.zheng@xxxxxxxxx>, "Ke, Liping" <liping.ke@xxxxxxxxx>, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Delivery-date: Mon, 01 Feb 2010 04:40:44 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <EB8593BCECAB3D40A8248BE0B6400A3835ACB174@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqfEjBdAvKTlDZES9GP92/daWtXOgBn3NcBAABXF2AAAn8xkQBvuV2QAAb4ydAAFXdH4AAK5Ei0AAUXLYAAA4f8eA==
Thread-topic: [Xen-devel] [PATCH] HVM vcpu hotplug: Fix acpi method NTFY bug
User-agent: Microsoft-Entourage/12.23.0.091001
On 01/02/2010 11:21, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:

> 5. a simple way to solve the issue is, to make sure scan loop of NTFY = scan
> loop of PRSC, and to make sure NTFY always scan 2^n vcpus.
>     However, NTFY scan loop may change in the future, not necessary equal to
> 2^n, and not necessary equal to scan loop of PRSC. That's the reason why I use
> for() loop inside of decision_tree() in method NTFY at the patch I send Jan
> 27. It will work correctly under whatever conditions, and keep mk_dsdt.c
> easier to understand. Decision_tree indeed reduce scan greatly, but it's not
> in key path.

Ah, now I understand!

Okay, how about the attached patch? This fixes the bug by inlining NTFY into
PRSC, and also uses HVM_MAX_VCPUS as appropriate.

Please take a look and also test it. I'll apply it if/when you Ack it.

 -- Keir

Attachment: 00-dsdt
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel