WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] HVM vcpu hotplug: Fix acpi method NTFY bug

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] HVM vcpu hotplug: Fix acpi method NTFY bug
From: "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>
Date: Sun, 31 Jan 2010 22:04:52 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "Zheng, Shaohui" <shaohui.zheng@xxxxxxxxx>, "Ke, Liping" <liping.ke@xxxxxxxxx>, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Delivery-date: Sun, 31 Jan 2010 06:05:15 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C7884C99.8087%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <EB8593BCECAB3D40A8248BE0B6400A3835ACA93C@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C7884C99.8087%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqfEjBdAvKTlDZES9GP92/daWtXOgBn3NcBAABXF2AAAn8xkQBvuV2Q
Thread-topic: [Xen-devel] [PATCH] HVM vcpu hotplug: Fix acpi method NTFY bug
Keir Fraser wrote:
> On 29/01/2010 07:32, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:
> 
>> suppose
>> x = scan loop number defined at method PRSC
>> y = scan loop number defined at method NTFY
>> in original way, there are 2 implicit precondition to make it work
>> right: 1). y = x 2). y = 2^n
>> however, these preconditions are not always be satisfied.
>> for example, if x > y, it will produce unexpected scan and block vcpu
>> add/remove.
> 
> Well, that didn't help. Some code comments would be handy.
> 
> Looking at method PRSC the algorithm seems pretty mad given we
> auto-generate the code. Apparently we *always* call NTFY for every
> value of 0<=Arg0<=127, in order? And then you would propose to do a
> further linear If chain within NTFY? Why not merge NTFY into PRSC: if
> you must have a linear scan anyway in PRSC, just unroll the while
> loops, and inline the relevant bit of NTFY for every unrolled loop
> invocation. 
> 
> And please provide some code comments relating this all back to the
> ACPI Spec, and explaining what the local variables represent, etc.
> It's totally impossible to understand right now. Although at least
> loop unrolling will get rid of several local variables...
> 
>  -- Keir
> 

Keir,

According to your suggestion, I plan to modify the patch as:
1. cancel method NTFY, merge it into method PRSC;
2. at method PRSC, only scan 'maxvcpus' times. we can transfer 'maxvcpus' 
(which comes from cmdline) from qemu to dsdt side through bios_info;
3. at mk_dsdt.c, add some comments to make it clear;
Do you think it OK?

Thanks,
Jinsong
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel