 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] trouble with the new mmap-batch interface
| To: | Brendan Cully <brendan@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] trouble with the new mmap-batch interface |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Wed, 20 Jan 2010 21:54:55 +0000 |
| Cc: | |
| Delivery-date: | Wed, 20 Jan 2010 13:55:25 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20100120213812.GC4658@xxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcqaGPhywV96Hbs5QQGx0YCjOW9cTAAAjrr4 |
| Thread-topic: | [Xen-devel] trouble with the new mmap-batch interface |
| User-agent: | Microsoft-Entourage/12.23.0.091001 |
On 20/01/2010 21:38, "Brendan Cully" <brendan@xxxxxxxxx> wrote: >> It seems unlikely to me that this is actual breakage, but I've built >> world a couple of times. Before I put printfs everywhere I thought I'd >> ask if anyone else had seen this or had any ideas. > > The attached patch fixes ioemu for me. So the issue is that the kernel only writes back the err array if there was at least one failure in the batch. Given the alternative is pre-zeroing the array, shouldn't we just unconditionally copy back the array, even if it is all zeroes? Jan: Is it in fact a bug, because IOCTL_PRIVCMD_MMAPBATCH is similarly structured (but legitimately, in that case)? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Contiguous DMAble memory in Dom0 user space linux process, Konrad Rzeszutek Wilk |
|---|---|
| Next by Date: | [Xen-devel] HVM live migration error, probably related to 20691:054042ba73b6, Brendan Cully |
| Previous by Thread: | Re: [Xen-devel] trouble with the new mmap-batch interface, Brendan Cully |
| Next by Thread: | Re: [Xen-devel] trouble with the new mmap-batch interface, Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
