WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] RE: [PATCH] xend: Fix non-contiguous NUMA node assignment

To: Andre Przywara <andre.przywara@xxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH] xend: Fix non-contiguous NUMA node assignment
From: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Date: Sun, 17 Jan 2010 10:10:42 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Delivery-date: Sat, 16 Jan 2010 18:11:05 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B506D7F.1050500@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4B506D7F.1050500@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqV5rITvhJHyZ8VQnCa2BKBWh2TTgBMsE0Q
Thread-topic: [PATCH] xend: Fix non-contiguous NUMA node assignment
I transfered this issue to Dexuan to have a look last week, because I'm busy on 
some MCA issue. 
Per my understanding, the refer to nr_nodes in xend python should be replaced 
by max_node_id, but I didn't look into detail of it.
I willhave a discussion with Dexuan on Monday.

--jyh

>-----Original Message-----
>From: Andre Przywara [mailto:andre.przywara@xxxxxxx]
>Sent: Friday, January 15, 2010 9:29 PM
>To: Keir Fraser
>Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; Jiang, Yunhong
>Subject: [PATCH] xend: Fix non-contiguous NUMA node assignment
>
>Hi,
>
>it seems that I missed a point in this whole addition of max_node_id. I
>see the difference in the Xen HV part, so nr_nodes got replaced with
>max_node_id in physinfo_t (and xc_physinfo_t, respectively).
>But where does this value help in xend? There is no single Python
>reference to the physinfo()'s max_node_id field, instead all functions
>use the old (but now bogus) nr_nodes variable.
>So in the attached patch I kept the xc.physinfo() returned dictionary
>with only a nr_nodes field, calculated by simply adding 1 to max_node_id
>from libxc. Empty nodes can (and will) be detected by iterating through
>the node_to_cpus and node_to_memory lists.
>Nodes without memory should not be considered during guest's memory
>allocation, but will be used for further CPU affinity setting if the
>number of VCPUs exceeds the number of cores per node.
>
>Please correct me if I am totally wrong on this, but this seems to work
>much better in my case.
>
>Regards,
>Andre.
>
>Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
>
>--
>Andre Przywara
>AMD-Operating System Research Center (OSRC), Dresden, Germany
>Tel: +49 351 448 3567 12
>----to satisfy European Law for business letters:
>Advanced Micro Devices GmbH
>Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
>Geschaeftsfuehrer: Andrew Bowd; Thomas M. McCoy; Giuliano Meroni
>Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
>Registergericht Muenchen, HRB Nr. 43632

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel