WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH, RFC 1/4] linux: add new (replacement) mmap-batch

To: Jan Beulich <JBeulich@xxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH, RFC 1/4] linux: add new (replacement) mmap-batch ioctl
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 11 Jan 2010 19:24:43 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 11 Jan 2010 11:25:15 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B4B54DC02000078000291A2@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqS1LSq8RLIRfW7RQyReLSKSCDcOwAHwVqV
Thread-topic: [Xen-devel] [PATCH, RFC 1/4] linux: add new (replacement) mmap-batch ioctl
User-agent: Microsoft-Entourage/12.23.0.091001
On 11/01/2010 15:42, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>>>  #define IOCTL_PRIVCMD_MMAPBATCH                                        \
>>>         _IOC(_IOC_NONE, 'P', 3, sizeof(privcmd_mmapbatch_t))
>>> +#define IOCTL_PRIVCMD_MMAP_BATCH                               \
>>> +       _IOC(_IOC_NONE, 'P', 4, sizeof(privcmd_mmap_batch_t))
>> 
>> Distinguishing the old vs new ioctl by only a _ in the middle seems a
>> bit horrid. MMAPBATCH2 would at least be less prone to confusion...
> 
> Otoh it clearly tells that the two are very similar...

As does MMAPBATCH2. I actually strongly suggest IOCTL_PRIVCMD_MMAPBATCH_V2,
which makes the situation even more crystal clear. Distinguishing based on a
single underscore, to make the new name 'nice', is misplaced aestheticism.
In particular, the tools end up referencing both names (for compatibility)
and a clearer name makes the code more intelligible.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel