WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: A question about changeset 20621:f9392f6eda79 and Di

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, "andre.przywara@xxxxxxx" <andre.przywara@xxxxxxx>
Subject: Re: [Xen-devel] Re: A question about changeset 20621:f9392f6eda79 and Discontinuous online node
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 06 Jan 2010 09:44:51 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 06 Jan 2010 01:45:16 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C76A0847.5882%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqOqEbbnXIv78APQI2JXa+pIXFSLwAAvgW+AADQapAAAQga/wAAkNfn
Thread-topic: [Xen-devel] Re: A question about changeset 20621:f9392f6eda79 and Discontinuous online node
User-agent: Microsoft-Entourage/12.23.0.091001
On 06/01/2010 09:28, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

>> Keir, thanks for pointing out this.The API is sufficient. We only need
>> changes
>> to python side to understand this. One minor thing is, maybe we need change
>> the nr_nodes from number of online node to the maxium of online node id,
>> otherwise, xc.physinfo may have no idea when iterate the node_to_memory
>> information (will it be possible the a node has only memory populated, while
>> no CPU populated?)
> 
> Yes, I think actually that would be a bug fix, given how tools currently use
> the nr_nodes field. Feel free to send a patch as part of your fix-up work: I
> don't think even changing the field name is necessary, but we can add a
> comemnt to sysctl.h.

Actually I think we should change the nr_cpus field in the same way, and may
as well change their names to max_cpu_id and max_node_id. I'll look into
this myself.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel