 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] Paging and memory sharing for HVM guests
| To: | Jan Beulich <JBeulich@xxxxxxxxxx>, Grzegorz Milos <gm281@xxxxxxxxx>, Patrick Colp <pjcolp@xxxxxxxxx>, Andrew Peace <Andrew.Peace@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Paging and memory sharing for HVM guests |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Mon, 04 Jan 2010 15:32:28 +0000 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Mon, 04 Jan 2010 07:32:54 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4B4205B90200007800028173@xxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcqNSCT149oONiStRdqtblKazxIpsAACvpQt |
| Thread-topic: | [Xen-devel] [PATCH] Paging and memory sharing for HVM guests |
| User-agent: | Microsoft-Entourage/12.23.0.091001 |
On 04/01/2010 14:14, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote: > Isn't this undermining the purpose of privcmd_enforce_singleshot_mapping()? > You don't check that the eventual single page re-mapping attempt is > really due to an earlier -ENOENT failure, and hence the whole single > shot mapping checks are now pointless (though other than possibly to > enforce some minimal security I don't really know what its purpose > is/was - Keir?). It was just to avoid the BUG_ON(!pte_none(*pte)) in direct_remap_area_pte_fn(). We trust privcmd users enough we could just get rid of privcmd_enforce_singleshot_mapping(). We could instead forcibly clear ptes before calling direct_remap_area(); or just do nothing. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] SLA Monitoring of XEN DomU's, Ahmad Hassan |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] Paging and memory sharing for HVM guests, Jan Beulich |
| Previous by Thread: | Re: [Xen-devel] [PATCH] Paging and memory sharing for HVM guests, Jan Beulich |
| Next by Thread: | Re: [Xen-devel] [PATCH] Paging and memory sharing for HVM guests, Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
