This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] xen_tlb_flush_all mfn validation panic

To: Kieran Mansley <kmansley@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] xen_tlb_flush_all mfn validation panic
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 24 Dec 2009 16:01:09 +0000
Delivery-date: Thu, 24 Dec 2009 08:01:37 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C75939F9.5334%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqEqryZuHWasn4dS4WA/TRApdEHNgAA4TPpAAEDSOY=
Thread-topic: [Xen-devel] xen_tlb_flush_all mfn validation panic
User-agent: Microsoft-Entourage/
On 24/12/2009 15:32, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

> On 24/12/2009 15:06, "Kieran Mansley" <kmansley@xxxxxxxxxxxxxx> wrote:
>> The initial "bad gmfn" message seems to be due to an attempt to validate
>> the mfn argument to the mmuext_op.  It's not surprising to me that this
>> fails as xen_tlb_flush_all doesn't supply an mfn argument - it's not
>> needed for the MMUEXT_TLB_FLUSH_ALL command.  Is there something that is
>> supposed to mean that the mfn argument should be valid even when not
>> explicitly set by the caller, or is the validation of the mfn for all
>> mmuext_op commands a bug?
> The explicit check for INVALID_MFN is new, and that is obviously a bug. I
> will sort out a suitable fix for this.

Should be fixed by c/s 20723.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>