This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 1 of 3] If Xen backend modules are not loaded, lo

To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1 of 3] If Xen backend modules are not loaded, load them before starting Xend
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Tue, 22 Dec 2009 14:57:53 -0500
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Tue, 22 Dec 2009 12:07:16 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1261510877.27802.19.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1261500535@xxxxxxxxxxxxxxxxxxx> <7bd805a543da685a3dba.1261500536@xxxxxxxxxxxxxxxxxxx> <1261510877.27802.19.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.19 (2009-01-05)
On Tue, Dec 22, 2009 at 07:41:17PM +0000, Ian Campbell wrote:
> On Tue, 2009-12-22 at 16:48 +0000, Konrad Rzeszutek Wilk wrote:
> > @@ -28,6 +28,7 @@
> >       grep '    xenfs$' /proc/filesystems >/dev/null && \
> >     ! grep '^xenfs ' /proc/mounts >/dev/null;
> >  then
> > +       modprobe -q xenfs
> >         mount -t xenfs xenfs /proc/xen
> >  fi
> >   
> I think this one gets requested automatically if the filesystem isn't
> currently present, see the call to request_module in
> fs/filesystems.c:get_fs_type()

Hmm, in 2.6.32 it looks to be usuable only once the filesystem has
loaded. This patch is for the case where the filesystem (xenfs) is compiled
as a module - and had not been loaded. Hence hadn't had a chance to call

Thought maybe I messing up this up. The "grep 'xenfs$' /proc/filesystem" checks
for xenfs in /proc/filesystem so it should not even get to the "then" statement.

Something is fishy here. Why don't we skip this patch and I will revist it
after holidays.

Xen-devel mailing list