This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] linux/balloon: prefer using pages from balloon i

To: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] linux/balloon: prefer using pages from balloon in alloc_empty_pages_and_pagevec()
From: Dave McCracken <dcm@xxxxxxxx>
Date: Fri, 18 Dec 2009 15:03:30 -0600
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 18 Dec 2009 13:04:01 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B2BA75B0200007800026A81@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4B2907320200007800026472@xxxxxxxxxxxxxxxxxx> <200912180832.54632.dcm@xxxxxxxx> <4B2BA75B0200007800026A81@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.12.4 (Linux/2.6.28; KDE/4.3.4; x86_64; ; )
On Friday 18 December 2009, Jan Beulich wrote:
> >Ok, yeah.  It frees up the page that's currently being worked on, then
> > jumps  to err: to clean up all the other pages in the pagevec and free
> > the pagevec. Is there something wrong about it that I'm missing?
> It should __free_pages(..., order) rather than __free_page(...).

Gah, you're right.  Of course.  Sorry.  I'll add that fix to my patch.

Dave McCracken

Xen-devel mailing list