This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix build failure in 32 environment

To: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix build failure in 32 environment
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 14 Dec 2009 17:45:43 +0000
Cc: "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 14 Dec 2009 09:46:14 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <9a0e85c3-db33-43bb-886e-1551c5417cd1@default>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acp83eVBnNb2trPpQN+VYe8zULp4bwAB1y+R
Thread-topic: [Xen-devel] [PATCH] Fix build failure in 32 environment
User-agent: Microsoft-Entourage/
On 14/12/2009 16:52, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

>> It can be supported for existign features but not all new ones. We can
>> perhaps retire it all together after 4.0.
> IMHO, this is not a new feature, this is an ABI incompatibility
> issue. If rdtscp is a valid 32-bit instruction, IMHO it
> should either work on both 32-bit Xen and 64-bit Xen or
> neither.

It only needs to work if we advertise RDTSCP in CPUID. Which we don't for
32-bit hosts. There's really nothing wrong with the patch that I can see.
I'd rather have the CPUID frobbing in xc_cpuid_x86.c, but it's a minor

 -- Keir

Xen-devel mailing list