This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [ PATCH 4/4 ] HVM vcpu add/remove: qemu logic for vcpu a

To: "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [ PATCH 4/4 ] HVM vcpu add/remove: qemu logic for vcpu add/revmoe
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 14 Dec 2009 09:33:13 +0000
Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Mon, 14 Dec 2009 01:33:31 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C74BA217.455B%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acp8HtRWWs29ZQxZRTqrRQcWGhMbYwAdUEXqAAMX2aU=
Thread-topic: [ PATCH 4/4 ] HVM vcpu add/remove: qemu logic for vcpu add/revmoe
User-agent: Microsoft-Entourage/
On 14/12/2009 08:04, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

> On 13/12/2009 18:05, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:
>> HVM vcpu add/remove: qemu logic for vcpu add/revmoe
>> -- at qemu side, get vcpu_avail which used for original cpu avail map;
>> -- setup gpe ioread/iowrite at qmeu;
>> -- setup vcpu add/remove user interface through monitor;
>> -- setup SCI logic;
> I'm guessing because this adds a new command-line option that I need this
> checked into the qemu tree before I can apply your first patch (1/4)?
> Otherwise that patch will break domain creation as qemu will exit with an
> 'unrecognised option' error. So I need Ian Jackson to apply this one and
> send me an updated QEMU_TAG first.

As of c/s 20640 all your Xen patches are checked in. I modified them a bit
so you may want to take a look. I commented out the one line that actually
sets the new qemu option, until that option is supported by our qemu. I
think there is a question over whether the new qemu option should (a) have a
better name (I called it vcpu_online[] in hvm_info structure); and (b)
should have a more user-friendly format (currently passing a decimal number
interpreted as a bitmap - perhaps should be a list of vcpus instead).

 -- Keir

Xen-devel mailing list