This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: RE: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support
From: "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx>
Date: Sat, 12 Dec 2009 00:22:34 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Fri, 11 Dec 2009 08:22:46 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B22591302000078000253E8@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <EADF0A36011179459010BDF5142A457501D13FE7E9@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4B224B6402000078000253AC@xxxxxxxxxxxxxxxxxx> <EADF0A36011179459010BDF5142A457501D13FE7FC@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4B22591302000078000253E8@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acp6ZwpMCV9u/gU0SuKrzR1CQiAxWgAFteAg
Thread-topic: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support
        Here is the updated one, I add the BUILD_BUG_ON() and some comments. 
Also CC Dan. Thanks!

Best Regards, 
-- Dongxiao

Jan Beulich wrote:
>>>> "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx> 11.12.09 14:10 >>>
>>      Thanks for reminder. I ever noticed this problem, but I forgot to
>> modify the code in that version. Attached is the updated one.
> Sorry, but I don't think this is any better. Sill no build-time
> checking, and still the potential for getting completely out of sync
> what is already very fragile (the VMX_INDEX_MSR_* enumeration and the
> msr_index array): 
> Just to repeat, what if somebody adds another enumerator (naturally)
> at the end (i.e. after VMX_INDEX_MSR_TSC_AUX), and the
> corresponding MSR index at the end of msr_index[]?
> Jan

Attachment: 02-add-hvm-rdtscp-support.patch
Description: 02-add-hvm-rdtscp-support.patch

Xen-devel mailing list