This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH 2] HVM vcpu add/remove: setup dsdt and madt infra

To: "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 2] HVM vcpu add/remove: setup dsdt and madt infrastructure for vcpu add/remove
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 10 Dec 2009 20:14:01 +0000
Delivery-date: Thu, 10 Dec 2009 12:14:30 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <706158FABBBA044BAD4FE898A02E4BC201CF7CA731@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acp4skvEix7hn2Q2TfebXz2pqbXZQAAD1LspADMqqRAAEcGopg==
Thread-topic: [PATCH 2] HVM vcpu add/remove: setup dsdt and madt infrastructure for vcpu add/remove
User-agent: Microsoft-Entourage/
On 10/12/2009 12:08, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:

>> What's PROC_BASE, and what's APIC_MADT_PTR? No comments attached to
>> them: they look like random magic numbers.
> KVM has vcpu add/remove code, these 2 items learn from KVM qemu/vbios/dsdt
> code.
> Since they belong to qemu & vbios part, I think we'd better keep same with
> KVM.
> I will add comments for them at updated patch.

Oh, I categorically do not care about keeping these magic numbers the same
as KVM/qemu. If there are some ioports or iomem emulated at fixed address by
qemu then that's one thing, but keeping their vbios random numbers when we
*do not use* the same vbios makes no sense.

I'd rather keep our MADT layout, add a few lines of code to hvmloader to
describe some MADT position/layout parameters to the DSDT via the bios_info
structure, and go from there. Smaller, clearer patch, as far as I can see.

 -- Keir

Xen-devel mailing list