This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] pvops-dom0 console freezes after latest ballooning patch

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Ronny.Hegewald@xxxxxxxxx
Subject: Re: [Xen-devel] pvops-dom0 console freezes after latest ballooning patch (+possible fix)
From: Dave McCracken <dcm@xxxxxxxx>
Date: Wed, 9 Dec 2009 14:20:22 -0600
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 09 Dec 2009 12:20:55 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B1FFFCA.9060701@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <846954254.901022.1260386535441.JavaMail.tomcat55@xxxxxxxxxxxxxxxxxxxxxxx> <4B1FFFCA.9060701@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.12.2 (Linux/2.6.28; KDE/4.3.2; x86_64; ; )
On Wednesday 09 December 2009, Jeremy Fitzhardinge wrote:
> On 12/09/09 11:22, Ronny.Hegewald@xxxxxxxxx wrote:
> > Setup: xen 3.4.1, 32-bit linux dom0 from pvops-git tree from
> > 2009-12-03
> >
> >
> > Since the latest ballooning patch "Add hugepage support to balloon
> > driver
> > <http://git.kernel.org/?p=linux/kernel/git/jeremy/xen.git;a=commit;h=0e89
> >8d5e9b893324435e0e77b67fe8d2f0523dbe>" i experience dom0 console freezes.
> > Additional to that there is a stacktrace about a kernel-bug in
> > drivers/xen/balloon.c in line 346, invalide opcode 0000 (i can send the
> > full stacktrace if someone is interested).
> Yes, please.  Presumably its from the BUG_ON testing the hypercall
> return status?
> > The cause for that seems to be that in the
> > decrease_reservation-funtion the PageHighMem - check is not executed
> > on the assocciated page for the current pfn. Its always the last page
> > that got allocated in the for-loop before, when all the pages are
> > allocated.
> >
> > With the attached patch that crashes dont occur anymore. But im not a
> > kernel-developer so im not sure that this is the correct fix.
> It looks reasonable to me.  Dave?
>      J

Yes, absolutely.  It's the correct fix.  Good catch.

Dave McCracken
Oracle Corp.

Xen-devel mailing list