This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] libxenlight: implement libxl_set_memory_target

To: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] libxenlight: implement libxl_set_memory_target
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Wed, 9 Dec 2009 13:19:52 +0000
Cc: Vincent Hanquez <Vincent.Hanquez@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>, Stefano
Delivery-date: Wed, 09 Dec 2009 05:16:21 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B1EB743.3090102@xxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20091208200031.4903B5980EB@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4B1EB743.3090102@xxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Tue, 8 Dec 2009, Andres Lagar-Cavilla wrote:
> Hi,
> couple of comments:
> - PV domains without videoram won't be able to use this

PV domains just have videoram = 0.

> - Further, doesn't the PV domain build function need to use 
> target_memkb? (That's my read of what xend does at least)

Yes, you are right, I'll fix this.

> - Finally, LIBXL_MAXMEM_CONSTANT looks like an "evil constant we should 
> avoid". Where did it come from?

I decided to introduce this constant after a discussion with developers
of the memory management functions in xapi: after thorough testing they
found that adding 1 MB to maxmem increases the robustness of the system.

BTW the current value of the constant is wrong because it should be
expressed in KB, I'll send a patch to fix this later today.

Xen-devel mailing list