This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] xen: use less generic names in netfront2 driver.

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] xen: use less generic names in netfront2 driver.
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Fri, 4 Dec 2009 16:10:55 +0000
Cc: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>
Delivery-date: Fri, 04 Dec 2009 08:13:01 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1259943018.23698.16496.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1259943018.23698.16496.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
All Xen frontend drivers have a couple of identically named functions which
makes figuring out which device went wrong from a stacktrace harder than it
needs to be. Rename them to something specificto the device type.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Cc: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
 drivers/net/xen-netchannel2/netfront2.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/xen-netchannel2/netfront2.c 
index f360b43..d5e12c0 100644
--- a/drivers/net/xen-netchannel2/netfront2.c
+++ b/drivers/net/xen-netchannel2/netfront2.c
@@ -342,7 +342,7 @@ static int allocate_rings(struct netfront2 *nf, domid_t 
        return 0;
-static void backend_changed(struct xenbus_device *xd,
+static void netback2_changed(struct xenbus_device *xd,
                            enum xenbus_state backend_state)
        struct netfront2 *nf = xenbus_device_to_nf2(xd);
@@ -498,7 +498,7 @@ static struct xenbus_driver netfront2 = {
        .ids = netfront_ids,
        .probe = netfront_probe,
        .remove = __devexit_p(netfront_remove),
-       .otherend_changed = backend_changed,
+       .otherend_changed = netback2_changed,
        .resume = netfront_resume,
        .suspend = netfront_suspend,

Xen-devel mailing list