This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] libxenlight: clone context to avoid GC corruptio

To: "Vincent Hanquez" <vincent.hanquez@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] libxenlight: clone context to avoid GC corruption
From: andres@xxxxxxxxxxxxxxxx
Date: Thu, 3 Dec 2009 07:18:39 -0800
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Thu, 03 Dec 2009 07:18:56 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20091203151110.GA16650@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4B16E586.7060505@xxxxxxxxxxxxxxxx> <20091203151110.GA16650@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: SquirrelMail/1.4.19
Well. I'm just a humble contributor :)
But if you feel like nacking this patch, it'd be nice if you provided
either a new "GC", or an alternate way to keep using the old "GC" while
using a separate xenstore handle in functions like libxl_xs_read. Or an
alternate solution to the watch problem.
> On Wed, Dec 02, 2009 at 10:09:10PM +0000, Andres Lagar-Cavilla wrote:
>> Provide a function to clone a context. This is necessary
>> because simply copying the structs will eventually
>> corrup the GC: maxsize is updated in the cloned context
>> but not in the originating one, yet they have the same
>> array of referenced pointers alloc_ptrs.
> I think this doesn't answer the question of why you need this function
> at all. I don't think you should clone the context nor share it.
> --
> Vincent

Xen-devel mailing list