WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] xen: reduce severity of message about using v1 g

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] xen: reduce severity of message about using v1 grant tables.
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Wed, 2 Dec 2009 19:54:42 +0000
Cc: Smith <Steven.Smith@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Steven
Delivery-date: Wed, 02 Dec 2009 11:55:08 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B16C103.9070105@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1259782098-32180-1-git-send-email-Ian.Campbell@xxxxxxxxxx> <4B16C103.9070105@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2009-12-02 at 19:33 +0000, Jeremy Fitzhardinge wrote: 
> On 12/02/09 11:28, Ian Campbell wrote:
> > From: Ian Campbell <ijc@xxxxxxxxxxxxxx>
> >
> > It's hardly the end of the world...
> >
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
> > Cc: Steven Smith <Steven.Smith@xxxxxxxxxxxxx>
> > ---
> >  drivers/xen/grant-table.c |   19 ++++++++++---------
> >  1 files changed, 10 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
> > index 2240adf..85ce951 100644
> > --- a/drivers/xen/grant-table.c
> > +++ b/drivers/xen/grant-table.c
> > @@ -699,21 +699,22 @@ static void gnttab_request_version(void)
> >  
> >     gsv.version = 2;
> >     rc = HYPERVISOR_grant_table_op(GNTTABOP_set_version, &gsv, 1);
> > -   if (rc == 0) {
> > +   if (rc == 0)
> >             grant_table_version = 2;
> > -           printk(KERN_NOTICE "Using V2 grant tables.\n");
> > -   } else {
> > +   else {
> >             if (grant_table_version == 2) {
> > -                   /* If we've already used version 2 features,
> > -                      but then suddenly discover that they're not
> > -                      available (e.g. migrating to an older
> > -                      version of Xen), almost unbounded badness
> > -                      can happen. */
> > +                   /*
> > +                    * If we've already used version 2 features,
> > +                    * but then suddenly discover that they're not
> > +                    * available (e.g. migrating to an older
> > +                    * version of Xen), almost unbounded badness
> > +                    * can happen.
> > +                    */
> >                     panic("we need grant tables version 2, but only version 
> > 1 is available");
> >   
> 
> Does it really need to be a panic?  Can't we just start failing all
> future operations?  Seems bad to take out the whole machine if we can
> just get away with crippling one device (especially if it can be
> recovered by downing it and re-upping a new one with nc1 and/or gt1).

Wouldn't there be (failing) grant table ops on the down path?

In any case doesn't it effect all devices since they all use the same
grant table?

Ian.

> 
>     J



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel