This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xen: don't leak IRQs over suspend/resume.

To: "Ian Campbell" <Ian.Campbell@xxxxxxxxxxxxx>, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xen: don't leak IRQs over suspend/resume.
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Wed, 02 Dec 2009 09:27:16 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 02 Dec 2009 01:30:40 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C73BDD4C.34E2%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4B1637CA0200007800022FB5@xxxxxxxxxxxxxxxxxx> <C73BDD4C.34E2%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 02.12.09 10:01 >>>
>On 02/12/2009 08:47, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
>>> Fix this by changing unbind_from_irq() to handle teardown of interrupts 
>>> which
>>> have type!=IRQT_UNBOUND but are not currently bound to a specific event
>>> channel.
>> This seems applicable to the 2.6.18/.27 trees too, doesn't it?
>Pv_ops' IRQ/evtchn handling is quite different from .18/27's. The latter
>don't have this issue -- we'd have noticed long ago if they did!

Oh, right, find_unbound_irq() in these trees doesn't look at the IRQ
type, but at irq_bindcount[], which is being updated in
unbind_from_irq() regardless of the event channel association.

Sorry for the noise,

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>