This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] x86: fix MCE/NMI injection

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [PATCH] x86: fix MCE/NMI injection
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Tue, 1 Dec 2009 11:39:25 +0100
Cc: Yunhong Jiang <yunhong.jiang@xxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>, Liping Ke <liping.ke@xxxxxxxxx>
Delivery-date: Tue, 01 Dec 2009 02:40:07 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B14F1CA0200007800022CC6@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4B14F1CA0200007800022CC6@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.10
On Tuesday 01 December 2009 10:36:58 Jan Beulich wrote:
> This attempts to address all the concerns raised in
> http://lists.xensource.com/archives/html/xen-devel/2009-11/msg01195.html,
> but I'm nevertheless still not convinced that all aspects of the
> injection handling really work reliably. In particular, while the
> patch here on top of the fixes for the problems menioned in the
> referenced mail also adds code to keep send_guest_trap() from
> injecting multiple events at a time, I don't think the is the right
> mechanism - it should be possible to handle NMI/MCE nested within
> each other.
> Another fix on top of the ones for the earlier described problems is
> that the vCPU affinity restore logic didn't account for software
> injected NMIs - these never set cpu_affinity_tmp, but due to it most
> likely being different from cpu_affinity it would have got restored
> (to a potentially random value) nevertheless.
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

The patch looks good. Just a minor nit: your cmpxchgptr() implementation
looks very complicated and unreadable.


---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>