WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [Patch]: conflicting sysctl numbers

To: "Kamble, Nitin A" <nitin.a.kamble@xxxxxxxxx>
Subject: [Xen-devel] [Patch]: conflicting sysctl numbers
From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date: Tue, 01 Dec 2009 07:46:10 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Mon, 30 Nov 2009 22:46:37 -0800
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1259649973; x=1291185973; h=from:sender:reply-to:subject:date:message-id:to:cc: mime-version:content-transfer-encoding:content-id: content-description:resent-date:resent-from:resent-sender: resent-to:resent-cc:resent-message-id:in-reply-to: references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:list-owner:list-archive; z=From:=20Juergen=20Gross=20<juergen.gross@xxxxxxxxxxxxxx> |Subject:=20[Patch]:=20conflicting=20sysctl=20numbers |Date:=20Tue,=2001=20Dec=202009=2007:46:10=20+0100 |Message-ID:=20<4B14BBB2.605@xxxxxxxxxxxxxx>|To:=20"Kambl e,=20Nitin=20A"=20<nitin.a.kamble@xxxxxxxxx>|CC:=20"xen-d evel@xxxxxxxxxxxxxxxxxxx"=20<xen-devel@xxxxxxxxxxxxxxxxxx m>,=20=0D=0A=20Keir=20Fraser=20<Keir.Fraser@xxxxxxxxxxxxx >|MIME-Version:=201.0|In-Reply-To:=20<8EA2C2C4116BF44AB37 0468FBF85A777010FC16205@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |References:=20<8EA2C2C4116BF44AB370468FBF85A777010FC1620 5@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>; bh=obTsCKYOeMKHa0ck2qFWgilPcWfhVe48HrwTH7JnYcM=; b=emM7Ay7u/aI9PH3WkStPEzFquI6jmklSUpGY6ckuyRKpw41pc9OKYfc7 hYYgWkkDOghVrY4OFoxYnicpWNv7y/6wheN0a8fxMWqtU3Tb8UXOTgNTT 9yvN2UVhNQIFIxGT3ClYeWoUX9O106nI8Nd4RqXkA9W6eaYEGbGG07Xp/ m4ssFdYaGBDY3FKSSeuFZU/m5Rnp3wD+ZxPcN+tpvuc+ivE9MVxdTjlMR DfiP2QZzxEoWvXO4uGE0wP5EsPfCK;
Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:X-Enigmail-Version:Content-Type; b=EGa5wrBe3CvuH5sfrERFF+ssAnPGKizEgvU4QJ26dTowoNnOHnpCaP83 7Te9/Q9PD+LS+ihY197zUzJL6xYcYG7Y5lT/E5Zgaf/5iKfZ9MhBy+brR +S0p4OXxRb0HzN2QTbTctxtKiRhzpstand4fgQAxV2HNEc7VPhd7p689U e1I+P1NeJncZCcWCt3+7lLXVrVNiMiDmKrW4MqtgE8vdPKGsvQ61hzJUL OYvthE4dE6/fRSt7HixAWVEQQfDaP;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <8EA2C2C4116BF44AB370468FBF85A777010FC16205@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Fujitsu Technology Solutions
References: <8EA2C2C4116BF44AB370468FBF85A777010FC16205@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090707)
Attached patch fixes the problem.

Kamble, Nitin A wrote:
> Keir,
> 
>  
> 
> I found there are two sysctls with conflicting same sysctl no in the
> code. This looks like a issue caused by merging code from different
> developers, and need fixing.
> 
> xen/include/public/sysctl.h
> 
> #define XEN_SYSCTL_cpu_hotplug       11
> 
> #define XEN_SYSCTL_lockprof_op       11
>  
> 
> Looks like this has come from changeset 20312:
> 
> Spinlock profiling (enable in build with lock_profile=y)


-- 
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technolgy Solutions               e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html
# HG changeset patch
# User juergen.gross@xxxxxxxxxxxxxx
# Date 1259649761 -3600
# Node ID b8915cc97db6189b1146e692c70cc1ea62baf776
# Parent  abc6183f486e66b5721dbf0313ee0d3460613a99

Signed-off-by: juergen.gross@xxxxxxxxxxxxxx

use free sysctl_op number

diff -r abc6183f486e -r b8915cc97db6 xen/include/public/sysctl.h
--- a/xen/include/public/sysctl.h       Mon Nov 30 10:58:23 2009 +0000
+++ b/xen/include/public/sysctl.h       Tue Dec 01 07:42:41 2009 +0100
@@ -454,7 +454,7 @@
 
 #define PG_OFFLINE_OWNER_SHIFT 16
 
-#define XEN_SYSCTL_lockprof_op       11
+#define XEN_SYSCTL_lockprof_op       15
 /* Sub-operations: */
 #define XEN_SYSCTL_LOCKPROF_reset 1   /* Reset all profile data to zero. */
 #define XEN_SYSCTL_LOCKPROF_query 2   /* Get lock profile information. */
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>