Re: [Xen-devel] [PATCH] x86/mm: set_p2m_entry() should return 0

At 05:16 +0000 on 27 Nov (1259298997), Kouya Shimura wrote:
> set_p2m_entry() ignores halfway errors.
> It should return 0 on error, shouldn't it?

Since all of its callers discard the return value, it hardly matters. :(
But yes, this patch makes the semantics more sensible. 

> Signed-off-by: Kouya Shimura <kouya@xxxxxxxxxxxxxx>

Acked-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>


-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Citrix Systems (R&D) Ltd.
[Company #02300071, SL9 0DZ, UK.]

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] x86/mm: set_p2m_entry() should return 0 on error, Kouya Shimura Re: [Xen-devel] [PATCH] x86/mm: set_p2m_entry() should return 0 on error, Keir Fraser Re: [Xen-devel] [PATCH] x86/mm: set_p2m_entry() should return 0 on error, Tim Deegan <=

Previous by Date:

[Xen-devel] [PATCH] libxenlight: add console command, Tomasz Wroblewski

Next by Date:

RE: [Xen-devel] Partial succes VGA passthrough Ati Radeon HD4850 on Asus P5Q-EM DO (Q45 chipset), Han, Weidong

Previous by Thread:

Re: [Xen-devel] [PATCH] x86/mm: set_p2m_entry() should return 0 on error, Keir Fraser

Next by Thread:

[Xen-devel] [PATCH][IOMMU] Free unused interrupt remapping table entry, Zhai, Edwin

Indexes:

[Date] [Thread] [Top] [All Lists]