This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Possible bug with pass-through hot-plug?

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Possible bug with pass-through hot-plug?
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Fri, 27 Nov 2009 09:47:40 +1100
Cc: Tom Rotenberg <tom.rotenberg@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 26 Nov 2009 14:48:01 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C7343910.2DBC%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20091124054844.GA21865@xxxxxxxxxxxx> <C7343910.2DBC%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
On Thu, Nov 26, 2009 at 01:54:24PM +0000, Keir Fraser wrote:
> On 24/11/2009 05:48, "Simon Horman" <horms@xxxxxxxxxxxx> wrote:
> > sorry for the extended delay, I was first busy with travel
> > and then with family. I'm finally back on deck and sifting through
> > my todo list.
> > 
> > Can you see if the patch below solves the problem that you were
> > observing. It seems to help in my test environment.
> > 
> > -----------------------------------------------------------------------------
> > 
> > hvmloader: pass-through: use O(log(n)) logic for hotplug events
> This looked good to me, but I think that all this per-slot logic in DSDT is
> a pain to manage manually. So I've applied a patch (xen-unstable:20510) to
> auto-generate those parts of the DSDT. Simon: you might want to take a look
> and also check that it does actually work. ;-)

Hi Keir,

that seems to work with the following minor modification in place.


build: Execute mk_dsdt with path

Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>

Index: xen-unstable.hg/tools/firmware/hvmloader/acpi/Makefile
--- xen-unstable.hg.orig/tools/firmware/hvmloader/acpi/Makefile 2009-11-27 
08:59:33.000000000 +1100
+++ xen-unstable.hg/tools/firmware/hvmloader/acpi/Makefile      2009-11-27 
09:45:32.000000000 +1100
@@ -36,7 +36,7 @@ dsdt.c: dsdt.asl mk_dsdt.c
        $(MAKE) iasl
        $(HOSTCC) $(HOSTCFLAGS) -o mk_dsdt mk_dsdt.c
        head -n -1 $< >_dsdt.asl
-       mk_dsdt >>_dsdt.asl
+       ./mk_dsdt >>_dsdt.asl
        iasl -tc _dsdt.asl
        mv _dsdt.hex dsdt.c
        echo "int DsdtLen=sizeof(AmlCode);" >> dsdt.c

Xen-devel mailing list