xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] tmem: fix freeable memory accounting error

from [Dan Magenheimer]

[Permanent Link][Original]

To:	"Xen-Devel (E-mail)" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [PATCH] tmem: fix freeable memory accounting error
From:	Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
Date:	Mon, 23 Nov 2009 11:42:33 -0800 (PST)
Delivery-date:	Mon, 23 Nov 2009 11:44:06 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Fix tmem accounting error that causes an "apparent"
memory leak, creating false negatives when testing
memory availability for launching a new domain.

Signed-off-by: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>

diff -r 5bfc7e343207 xen/include/xen/tmem_xen.h
--- a/xen/include/xen/tmem_xen.h        Mon Nov 23 11:08:51 2009 -0700
+++ b/xen/include/xen/tmem_xen.h        Mon Nov 23 12:39:37 2009 -0700
@@ -229,7 +229,7 @@ static inline struct page_info *tmh_allo
     if ( pi == NULL && !no_heap )
         pi = alloc_domheap_pages(0,0,MEMF_tmem);
     ASSERT((pi == NULL) || IS_VALID_PAGE(pi));
-    if ( pi != NULL )
+    if ( pi != NULL && !no_heap )
         atomic_inc(&freeable_page_count);
     return pi;
 }

tmem-freeable.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] tmem: fix freeable memory accounting error, Dan Magenheimer <=

Previous by Date:	[Xen-devel] tmem: fix another race in tmem on domain destroy, Dan Magenheimer
Next by Date:	[Xen-devel] tg3.ko not created after compilation of Xen 3.4.2 from sources, Artur Linhart - Linux communication
Previous by Thread:	[Xen-devel] tmem: fix another race in tmem on domain destroy, Dan Magenheimer
Next by Thread:	[Xen-devel] tg3.ko not created after compilation of Xen 3.4.2 from sources, Artur Linhart - Linux communication
Indexes:	[Date] [Thread] [Top] [All Lists]