WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 3 of 5] pygrub: factor generic Grub functionality

To: "ian.campbell@xxxxxxxxxx" <ian.campbell@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3 of 5] pygrub: factor generic Grub functionality into GrubConf base classes
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 23 Nov 2009 07:20:55 +0000
Cc:
Delivery-date: Sun, 22 Nov 2009 23:21:24 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <d641f06a4889748dc7ef.1258917301@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcprqH81IBATcCjIQIWUjf6z/gvQYgAZP+FT
Thread-topic: [Xen-devel] [PATCH 3 of 5] pygrub: factor generic Grub functionality into GrubConf base classes
User-agent: Microsoft-Entourage/12.23.0.091001
On 22/11/2009 19:15, "ian.campbell@xxxxxxxxxx" <ian.campbell@xxxxxxxxxx>
wrote:

> pygrub: factor generic Grub functionality into GrubConf base classes
> and inherit from these classes to implement Grub-legacy functionality.
> 
> Use a tuple of (parser-object,configuration-file) in pygrub to allow
> for multiple parsers.
> 
> Makes way for grub2 support.

This patch didn't apply for me. It may be due to mangling at my end or yours
because of sending the patch inline. Try resending it as an attachment,
along with patches 4/5 and 5/5 (I have already successfully applied 1/5 and
2/5).

 Thanks,
 Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel