This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Dont call msi_unmap_pirq() if did not enabled ms

To: "Joe Jin" <joe.jin@xxxxxxxxxx>, "Konrad Rzeszutek Wilk" <konrad.wilk@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Dont call msi_unmap_pirq() if did not enabled msi
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Tue, 17 Nov 2009 07:59:06 +0000
Cc: Kurt Hackel <kurt.hackel@xxxxxxxxxx>, Jerry Yuanjiang Ou <yuanjiang.ou@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, greg.marsden@xxxxxxxxxx
Delivery-date: Mon, 16 Nov 2009 23:59:52 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20091117001909.GA18296@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20091116120030.GA13803@xxxxxxxxxxxxxxxxxxxxxxx> <20091116151546.GC30967@xxxxxxxxxxxxxxxxxxx> <20091117001909.GA18296@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Joe Jin <joe.jin@xxxxxxxxxx> 17.11.09 01:19 >>>
>--- a/drivers/pci/msi-xen.c    Fri Oct 23 10:07:22 2009 +0100
>+++ b/drivers/pci/msi-xen.c    Tue Nov 17 08:16:42 2009 +0800
>@@ -673,6 +673,12 @@
>       if (!pos)
>               return;
>+      if (!(dev->msi_enabled)) {
>+              printk(KERN_INFO "PCI: %s: Device did not enabled MSI.\n",
>+                     pci_name(dev));
>+              return;
>+      }
>       pirq = dev->irq;
>       /* Restore dev->irq to its default pin-assertion vector */
>       dev->irq = msi_dev_entry->default_irq;

But shouldn't this happen before the CONFIG_XEN_PCIDEV_FRONTEND
conditional block? This one also calls evtchn_map_pirq(..., 0), i.e. would
also result in the storing of no_irq_chip.


Xen-devel mailing list