WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] compile error with pvops and pcifront

To: "James Harper" <james.harper@xxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] compile error with pvops and pcifront
From: "James Harper" <james.harper@xxxxxxxxxxxxxxxx>
Date: Sun, 15 Nov 2009 16:24:02 +1100
Cc:
Delivery-date: Sat, 14 Nov 2009 21:24:31 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AEC6C66638C05B468B556EA548C1A77D0180D44E@trantor>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AEC6C66638C05B468B556EA548C1A77D0180D44E@trantor>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcplsP0HIt58FA9jTzKUUvYVZOZfwgAAsuyw
Thread-topic: [Xen-devel] compile error with pvops and pcifront
> Either CONFIG_XEN_PCIDEV_FRONTEND should not be allowed to be a
module,
> or CONFIG_XEN_PCIDEV_FRONTEND_MODULE needs to be checked for like:
> 
> diff --git a/arch/x86/include/asm/xen/pci.h
> b/arch/x86/include/asm/xen/pci.h
> index 6c022c8..7b99422 100644
> --- a/arch/x86/include/asm/xen/pci.h
> +++ b/arch/x86/include/asm/xen/pci.h
> @@ -35,7 +35,9 @@ static inline int xen_setup_msi_irqs(struct pci_dev
> *dev, int nvec, int type)
>         return -1;
>  }
>  #endif
> -#if defined(CONFIG_PCI_MSI) && defined(CONFIG_XEN_PCIDEV_FRONTEND)
> +
> +#if defined(CONFIG_PCI_MSI) && (defined(CONFIG_XEN_PCIDEV_FRONTEND) \
> +      || defined(CONFIG_XEN_PCIDEV_FRONTEND_MODULE))
>  /* Defined in drivers/pci/xen-pcifront.c */
>  int pci_frontend_enable_msi(struct pci_dev *dev, int **vectors);
>  void pci_frontend_disable_msi(struct pci_dev *dev);
> 
> linewrapping probably destroyed the patch but it should be obvious
what
> is wrong.
> 

That's still not enough though - I get a link failure after that.

James

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>