Re: [Xen-devel] Re: [RFC] draft tsc_mode patch (to replace tsc_n

To:	Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, "Xen-Devel (E-mail)" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] Re: [RFC] draft tsc_mode patch (to replace tsc_native)
From:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date:	Fri, 13 Nov 2009 15:21:33 +0000
Cc:
Delivery-date:	Fri, 13 Nov 2009 07:22:28 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<6314d2a2-2eb2-4ce7-804f-a12e2c16d678@default>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcpkcpMUhX8J/V8tTEKFQI62se158QAAmhOe
Thread-topic:	[Xen-devel] Re: [RFC] draft tsc_mode patch (to replace tsc_native)
User-agent:	Microsoft-Entourage/12.20.0.090605

On 13/11/2009 15:03, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

> Yeah, it would be nice if tsc_mode could accept
> either a number or a word, but if it is a missssspelled
> word, I'd hope that domain creation would fail
> rather than proceed with the default.
> 
> Such python magic is beyond me so I hope it won't
> stand in the way of acceptance of the patch,
> as (especially if the word version is optional)
> someone else could make the change later....
> I'd propose 0==default, 1==emulate, 2==native,
> 3==pvrdtscp (and I've missssspelled that myself
> more than once!)
> 
> In any case, any other comments, or does it look
> reasonable to proceed and finish?

Looks fine to me.

 K.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] Re: [RFC] draft tsc_mode patch (to replace tsc_native)