This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: [PATCH] Don't assume the vcpu_id is continous in alloc_v

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH] Don't assume the vcpu_id is continous in alloc_vcpu
From: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Date: Fri, 13 Nov 2009 00:11:13 +0800
Accept-language: en-US
Acceptlanguage: en-US
Delivery-date: Thu, 12 Nov 2009 08:11:35 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C721E29D.BECD%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E2263E4A5B2284449EEBD0AAB751098418E55575D7@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C721E29D.BECD%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcpjiGc6hZlnMOBYRPSWYjjerzo1vQAA1c0HAAO2138ABCG/kAABrkn/AAAuzSA=
Thread-topic: [PATCH] Don't assume the vcpu_id is continous in alloc_vcpu
Aha, yes. I just checked the beginning of the do_domctl, sorry for wrong alerm.


Keir Fraser wrote:
> On 12/11/2009 15:27, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx> wrote:
>> Thanks for your changes very much.
>> I just noticed I missed get a lock for this change.
>> Originally I thought the XEN_DOMCTL_max_vcpus will be synced, but
>> seems no. So alloc_vcpu() may have race condition. (for idle_vcpu or
>> dom0, it should be safe already)
> All domctl operations are serialised on domctl_lock. I think
> that suffices?
> -- Keir
Xen-devel mailing list