WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] Add hypercall to expose physical CPU in xen

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] Add hypercall to expose physical CPU in xen hypervisor
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Tue, 10 Nov 2009 10:00:25 -0800
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Tue, 10 Nov 2009 10:02:19 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20091110163626.GC23000@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C71C27D1.1974B%keir.fraser@xxxxxxxxxxxxx> <4AF891B6.8010003@xxxxxxxx> <E2263E4A5B2284449EEBD0AAB751098418E5238629@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20091110163626.GC23000@xxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4
On 11/10/09 08:36, Konrad Rzeszutek Wilk wrote:
> Here is what checkpatch says:
>
> WARNING: do not add new typedefs
> #523: FILE: include/xen/interface/platform.h:328:
> +typedef struct xen_physical_cpuinfo xen_physical_cpuinfo_t;
>
> WARNING: do not add new typedefs
> #537: FILE: include/xen/interface/platform.h:342:
> +typedef struct xenpf_pcpu_info xenpf_pcpu_info_t;
>
> total: 0 errors, 2 warnings, 564 lines checked
>
> /home/konrad/01-dom0_pcpu.patch has style problems, please review.  If any of 
> these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>   

Unfortunately I think the typedefs are necessary for the GUEST_HANDLE stuff.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel