This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] x86 boot: simplify reloc.c

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] x86 boot: simplify reloc.c
From: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxx>
Date: Tue, 10 Nov 2009 16:21:20 +0800
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Xiao Guangrong <ericxiao.gr@xxxxxxxxx>
Delivery-date: Tue, 10 Nov 2009 00:23:50 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C71EC891.19B0B%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C71EC891.19B0B%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (Windows/20070728)

Keir Fraser wrote:
> On 10/11/2009 03:34, "Xiao Guangrong" <xiaoguangrong@xxxxxxxxxxxxxx> wrote:
>> This patch simplify reloc.c with:
>> 1): no need separate make
>>     reloc.c -> reloc.o -> reloc.lnk -> reloc.bin -> reloc.S,
>>     and static embed reloc.S into head.S
>> 2): reuse memcpy() in string lib
>> 3): remove assemble code in the head of reloc.c
>> [ It is just a cleanup patch and not change the code's logic, and it work 
>> well
>> on x86.
>>   Not have x86_64 machine in my hand, thanks very much if someone can test it
>> on x86_64 ]
> The patch misses the point of reloc.c, which is that it is supposed to run
> in 32-bit mode. All the stuff you stripped out is exactly what's needed to
> make it work with 64-bit Xen.

Ah, sorry for this noise, I'll do some work on x86-64 about this patch.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>