WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 29/31] xen_destroy_irq + xen_allocate_pirq in PV

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 29/31] xen_destroy_irq + xen_allocate_pirq in PV non-priv mode should not make certain Xen-HYPERCALLs.
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Fri, 06 Nov 2009 13:38:15 -0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 06 Nov 2009 13:38:54 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1257456819-782-30-git-send-email-konrad.wilk@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1257456819-782-1-git-send-email-konrad.wilk@xxxxxxxxxx> <1257456819-782-15-git-send-email-konrad.wilk@xxxxxxxxxx> <1257456819-782-16-git-send-email-konrad.wilk@xxxxxxxxxx> <1257456819-782-17-git-send-email-konrad.wilk@xxxxxxxxxx> <1257456819-782-18-git-send-email-konrad.wilk@xxxxxxxxxx> <1257456819-782-19-git-send-email-konrad.wilk@xxxxxxxxxx> <1257456819-782-20-git-send-email-konrad.wilk@xxxxxxxxxx> <1257456819-782-21-git-send-email-konrad.wilk@xxxxxxxxxx> <1257456819-782-22-git-send-email-konrad.wilk@xxxxxxxxxx> <1257456819-782-23-git-send-email-konrad.wilk@xxxxxxxxxx> <1257456819-782-24-git-send-email-konrad.wilk@xxxxxxxxxx> <1257456819-782-25-git-send-email-konrad.wilk@xxxxxxxxxx> <1257456819-782-26-git-send-email-konrad.wilk@xxxxxxxxxx> <1257456819-782-27-git-send-email-konrad.wilk@xxxxxxxxxx> <1257456819-782-28-git-send-email-konrad.wilk@xxxxxxxxxx> <1257456819-782-29-git-send-email-konrad.wilk@xxxxxxxxxx> <1257456819-782-30-git-send-email-konrad.wilk@oracl e.com>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4
On 11/05/09 13:33, Konrad Rzeszutek Wilk wrote:
> The privileged domain should make these calls for the guest.
> The non-privileged domain should make these calls via the pcifront
> interface (patches that augment these two functions to do so
> will follow).
>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
>  drivers/xen/events.c |   30 ++++++++++++++++--------------
>  1 files changed, 16 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> index 40bcbde..fd55b5b 100644
> --- a/drivers/xen/events.c
> +++ b/drivers/xen/events.c
> @@ -606,14 +606,15 @@ int xen_destroy_irq(int irq)
>       if (!desc)
>               goto out;
>  
> -     unmap_irq.pirq = info->u.pirq.nr;
> -     unmap_irq.domid = info->u.pirq.domid;
>   

This doesn't apply to my tree because these lines read:
    unmap_irq.pirq = info->u.pirq.nr;
    unmap_irq.domid = DOMID_SELF;

I'm not sure where the creep happened.  Oh, perhaps because I applied
the pcifront and back series in different branches?  Ah, yes, that's
it.  I'll see if I can sort it out.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>