This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH 09 of 11] blktap2: only open driver stack once

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH 09 of 11] blktap2: only open driver stack once
From: Brendan Cully <brendan@xxxxxxxxx>
Date: Thu, 05 Nov 2009 14:58:34 -0800
Cc: andy@xxxxxxxxx
Delivery-date: Thu, 05 Nov 2009 15:07:12 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <patchbomb.1257461905@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1257461905@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mercurial-patchbomb/1.3.1+336-38deec407f8d
# HG changeset patch
# User Ryan O'Connor <rjo@xxxxxxxxx>
# Date 1252530408 25200
# Node ID b14bb76b36dd239586b41c47e6f2531cbcbf4b47
# Parent  4ca00ee41ce9731b8725c736b27c841b484dce5d
blktap2: only open driver stack once

Currently blktap2 opens a driver stack, closes it, and re-opens it. This
causes problems with our remus driver: the primary may connect to the
backup in between the first and second open.

This is a temporary fix.

Signed-off-by: Ryan O'Connor <rjo@xxxxxxxxx>

diff --git a/tools/blktap2/drivers/tapdisk-vbd.c 
--- a/tools/blktap2/drivers/tapdisk-vbd.c
+++ b/tools/blktap2/drivers/tapdisk-vbd.c
@@ -1561,9 +1561,11 @@
        gettimeofday(&vreq->last_try, NULL);
        tapdisk_vbd_move_request(vreq, &vbd->pending_requests);
+#if 0
        err = tapdisk_vbd_check_queue(vbd);
        if (err)
                goto fail;
        err = tapdisk_image_check_ring_request(image, req);
        if (err)

Xen-devel mailing list