This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel][PATCH] ioemu: fix drive name parsing

To: "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel][PATCH] ioemu: fix drive name parsing
From: "Yang, Xiaowei" <xiaowei.yang@xxxxxxxxx>
Date: Thu, 05 Nov 2009 18:08:05 +0800
Delivery-date: Thu, 05 Nov 2009 02:09:04 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4AF27686.4020100@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4AF27686.4020100@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20090817)
Yang, Xiaowei writes ("[Xen-devel] [PATCH] ioemu: fix drive name parsing"):
 > In xenstore_parse_domain_config(), 'any_hdN' is overridden by local version
 > accidentally.

Thanks for spotting this.  You're right that it's a bug.  I've applied
your patch (although really I think this whole area is pretty grotty
and could do with substantial rework).

Two comments though about the formatting of your patch:

  * It didn't apply cleanly because it had different whitespace to
   that in the actual code.  Your mailer must have done something to

There must be something wrong when I did the paste.

   it I think.  Best practice seems to be (if you can't make your
   mailer reliably not mangle the body of the message) to provide each
   patch _both_ as an attachment (for application) _and_ by including
   it in the body (for readable review).

Thanks for the advice. I'll attach the patch also next time.

  * You forgot the Signed-off-By line, by which you would certify that

I added the signed-off-by line at the bottom!:)


   the code copyright and so forth status was appropriate (according
   to the Developer's Certificate of Origin).  I applied your patch
   anyway because it's a one-line change (which most authorities think
   makes it too small for copyright to apply) but you should make sure
   to appropriately certify your code in future.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>