This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xc_resume: fix modify_returncode when PV guest w

To: Brendan Cully <brendan@xxxxxxxxx>, Xen Developers <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xc_resume: fix modify_returncode when PV guest width != host width
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 04 Nov 2009 22:09:58 +0000
Delivery-date: Wed, 04 Nov 2009 14:10:34 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20091104210324.GA9535@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acpdkl23UZi5Qf+BQ+SXajqtK7xO4QACS4QL
Thread-topic: [Xen-devel] [PATCH] xc_resume: fix modify_returncode when PV guest width != host width
User-agent: Microsoft-Entourage/
On 04/11/2009 21:03, "Brendan Cully" <brendan@xxxxxxxxx> wrote:

> It seems that xm save -c breaks PV guests when their address width
> does not match that of domain 0. It looks to me like modify_returncode
> is treating the guest VCPU context as native format, but honestly I
> don't quite understand the purpose of vcpu_guest_context_any_t.c.
> I suspect I'm missing something obvious about how the compat code is
> supposed to work, but at any rate, the attached patch fixes things for
> me.

No, the code's just stupid and broken. There's a similar bug in
xc_domain_resume_any(), accessing ctxt.c.user_regs.edx. I will fix both.


Xen-devel mailing list