This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: c/s 20384

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: [Xen-devel] Re: c/s 20384
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 02 Nov 2009 09:40:44 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 02 Nov 2009 01:41:17 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4AEEA3BB020000780001D146@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcpblPkVwaj5zHN0RDuJY/vdIRNDRAAC5M1t
Thread-topic: c/s 20384
User-agent: Microsoft-Entourage/
On 02/11/2009 08:17, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> - map_vcpu_info() no longer sets evtchn_upcall_mask for a newly mapped
> info struct
> - VCPUOP_initialise no longer fails when a vCPU didn't have a proper info
> struct installed
> - the changes to xen/common/event_channel.c make it so that
> dummy_vcpu_info can be written to, and hence subsequently initialized
> vcpu_info structs would have unpredictable initial state

Thanks, I've applied fixes as c/s 20390. The first issue is a genuine bug.
The second I think is not a critical issue, but since no good comes of
starting a vcpu without its own info structure, we may as well
check-and-fail in this case. The third issue I think does not matter, since
the first two fixes ensure that a vcpu will have a cleanly-initialised info
structure before it ever runs.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>