WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Xen-changelog] [xen-unstable] stubdom: mmap on /dev/mem

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [Xen-changelog] [xen-unstable] stubdom: mmap on /dev/mem support
From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
Date: Wed, 21 Oct 2009 17:36:49 +0200
Cc: xen-changelog@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 21 Oct 2009 08:37:12 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200910211510.n9LFAGT7019922@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, xen-changelog@xxxxxxxxxxxxxxxxxxx
References: <200910211510.n9LFAGT7019922@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.12-2006-07-14
Xen patchbot-unstable, le Wed 21 Oct 2009 08:10:15 -0700, a écrit :
> +        unsigned long mfns[n];
> +        for (i = 0; i < n; i++)
> +            mfns[i] = ((unsigned long) offset + (i * PAGE_SIZE)) >> 
> PAGE_SHIFT;

Mmm, is there a reason for adding (i*PAGE_SIZE) before right-shifting?

> +        return map_frames_ex(mfns, n, 1, 0, 1, DOMID_IO, 0, 
> _PAGE_PRESENT|_PAGE_RW);

Actually I think the whole could just be

        unsigned long first_mfn = offset >> PAGE_SHIFT;
        return map_frames_ex(&first_mfn, n, 0, 1, 1, DOMID_IO, 0, 
_PAGE_PRESENT|_PAGE_RW);

which avoids the need to prepare a table.

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>