WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] pt_msix_init: Error: Can't map physical MSI-X ta

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] pt_msix_init: Error: Can't map physical MSI-X table: Invalid argument
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Wed, 21 Oct 2009 11:20:44 +0100
Delivery-date: Wed, 21 Oct 2009 03:21:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <45c43ef50910201712qce79e09lbaa15167f2a4c28f@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <45c43ef50910201712qce79e09lbaa15167f2a4c28f@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Bruce Edge writes ("[Xen-devel] [PATCH] pt_msix_init: Error: Can't map physical 
MSI-X  table: Invalid argument"):
> I submitted this patch last week and did'nt see any feedback or indication
> as to why it would not be accepted.
> This is a confirmed tested fix that is required for pci passthorugh with
> msi-x.

This looks like a sensible patch.

> If there is something wrong with the format or the contents please let me
> know so that I can fix and resubmit.

However, your mail program has mangled it:

> --- ./tools/ioemu-remote/hw/pass-through.h.orig 2009-10-15
> 10:22:17.000000000 -0700

^ Here it has linewrapped it.

>    struct msix_entry_info msix_entry[0];
> +       uint32_t table_offset_adjust;   /* page align mmap */
>  };

^ And here the indentation is wrong (perhaps you have literal tabs
with a tab width of 2 or something).

Can you try to resubmit it please ?  Try including the patch as an
attachment as well as in the body of the message.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel