[Xen-devel] Re: [PATCH] Update cr3 in PAE mode when guest walk s

To:	George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Subject:	[Xen-devel] Re: [PATCH] Update cr3 in PAE mode when guest walk succeed but shadow walk fails
From:	Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date:	Wed, 21 Oct 2009 11:46:00 +0200
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Wed, 21 Oct 2009 02:46:40 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<de76405a0910160609g5bc1372i5573ba10bb37fbfa@xxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<de76405a0910160609g5bc1372i5573ba10bb37fbfa@xxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4

The attached patch solves the problem by calling update_cr3() in that
path when the guest is in PAE mode, and only ASSERT()ing when the
guest is not in PAE mode.  The guest will get one spurious page fault,
but subsequent accesses will succeed.


Hi George,

I suppose this patch is also needed when running 32-on-64. In thatcase, shouldn't the test be


#if GUEST_PAGING_LEVELS >= 3

rather than "== 3"?

Thanks,

Paolo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

[Xen-devel] Re: [PATCH] Bug in xmalloc_bytes(), Keir Fraser

Next by Date:

Re: [Xen-devel] Re: [PATCH] Update cr3 in PAE mode when guest walk succeed but shadow walk fails, Tim Deegan

Previous by Thread:

Re: [Xen-devel] [PATCH] Update cr3 in PAE mode when guest walk succeed but shadow walk fails, John Levon

Next by Thread:

Re: [Xen-devel] Re: [PATCH] Update cr3 in PAE mode when guest walk succeed but shadow walk fails, Tim Deegan

Indexes:

[Date] [Thread] [Top] [All Lists]

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] Re: [PATCH] Update cr3 in PAE mode when guest walk succeed b