WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] PG_blkback handling issue?

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] PG_blkback handling issue?
From: jake wires <jake.wires@xxxxxxxxx>
Date: Mon, 19 Oct 2009 11:31:50 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 19 Oct 2009 11:32:17 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=B1ZWpON53UCFqDnXXFXT9UVF/Mxj4NyGNWBSSL8uTXg=; b=F+p45CKTiajDwOEsSXuqZFnLf6kLaXK+Bf1dVyUGmdKde/g73ObyqCnrdpTt3iPsyF EnjCdB69nosORJW805hUKuTK+lzv72Y/waEXUI9wUcvYgnoNGXzqANAd0yB/2ek2aqGg puwdT2yjIAXP+VhjJ/l1Lsv8GOiZICWNzRdEo=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=bZuQUhoEHFbWb/sdwRDgvcsrTBa0F4NPBxlgqLZzvy5MwNhxSnFiF5usnr0tAP/nEw DlcDuLgdGdTAxgy7ShEOKMzRqlf/7x2lV3vaK6J5ZH/xHeARAJJNwyv1W/OKTczKqfqK s67ZwQSVaha4Nt1pzn8rc4Mtd2v56mfB1xoic=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4AD841D1020000780001A3D2@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4AD841D1020000780001A3D2@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
This flag is only ever set for special pages acquired in blkback (and blktap2) via alloc_empty_pages_and_pagevec(), so in a sense the PG_blkback flag always does apply, but I suppose it would be safe to clear it in blkback_pagemap_clear().

Jake

On Fri, Oct 16, 2009 at 12:50 AM, Jan Beulich <JBeulich@xxxxxxxxxx> wrote:
This flag, introduced with blktap2, seems to be sticky when blktap2 isn't
actively involved in any operations, since blkback-pagemap.c is only ever
setting or testing this bit. Shouldn't blkback_pagemap_clear() clear it?

And it would seem to me that, for safety purposes, both PG_blkback and
PG_netback should be included in the checks in mm/page_alloc.c which
already look at PG_foreign and (for ix86) PG_pinned.

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>