WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 08/13] Xen paravirtualised PCI hotplug.

To: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>, Yosuke Iwamatsu <y-iwamatsu@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 08/13] Xen paravirtualised PCI hotplug.
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Mon, 19 Oct 2009 10:50:36 -0400
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Yosuke Iwamatsu <y-iwamatsu@xxxxxxxxxxxxx>
Delivery-date: Mon, 19 Oct 2009 08:00:20 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4AD8522B.2070504@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1255468952-27052-1-git-send-email-konrad.wilk@xxxxxxxxxx> <1255468952-27052-2-git-send-email-konrad.wilk@xxxxxxxxxx> <1255468952-27052-3-git-send-email-konrad.wilk@xxxxxxxxxx> <1255468952-27052-4-git-send-email-konrad.wilk@xxxxxxxxxx> <1255468952-27052-5-git-send-email-konrad.wilk@xxxxxxxxxx> <1255468952-27052-6-git-send-email-konrad.wilk@xxxxxxxxxx> <1255468952-27052-7-git-send-email-konrad.wilk@xxxxxxxxxx> <1255468952-27052-8-git-send-email-konrad.wilk@xxxxxxxxxx> <1255468952-27052-9-git-send-email-konrad.wilk@xxxxxxxxxx> <4AD8522B.2070504@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.19 (2009-01-05)
>> +    XenbusStateReconfiguring = 7,
>> +
>> +    XenbusStateReconfigured  = 8
>>  };
>>   
> ouch.
>
> what's the usefulness of those 2 new states here ?

The changes came originally from the c/s 17223, which was titled:
Add PV passthrough PCI device hotplug support.

The short summary of that is that you can dynamically attach
PCI devices by doing: 'xm pci-attach'. And also detach by doing 'xm 
pci-dettach'.

> the xenbus state is just here to represent the connection status of the  
> xenbus device, doesn't reconfiguring/reconfigured state is something  
> about the underlying device more than the xenbus device ?

I suppose it is. Thought it is more of a state of evolution - the blkback
device could support changing of size dynamically (for example if it was mounted
on raw LUN which changed size as well). Or if the blkback was binded to a CD-ROM
device - support reconfiguring it (new media perhaps?).

>
> And regarding the xenbus-state state machine, what happen when you reach 8 ?
> does every userspace handler need to handle it as a 4 ? if yes why is it  
> not 4 ?

Good question. Lets ask Yosuke Iwamatsu who posted the initial
patch for this.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>