WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] RE: [Xen-changelog] [xen-unstable]vt-d: Fixpanic in msi_

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Miroslav Rezanina <mrezanin@xxxxxxxxxx>
Subject: Re: [Xen-devel] RE: [Xen-changelog] [xen-unstable]vt-d: Fixpanic in msi_msg_read_remap_rte with acpi=off
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 19 Oct 2009 12:51:52 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Dexuan Cui <dexuan.cui@xxxxxxxxx>
Delivery-date: Mon, 19 Oct 2009 04:53:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C7020F85.17E3F%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcpQrfYaPJP/l2nLTzW4nI+GixWepgAA3Y3kAABH+R0=
Thread-topic: [Xen-devel] RE: [Xen-changelog] [xen-unstable]vt-d: Fixpanic in msi_msg_read_remap_rte with acpi=off
User-agent: Microsoft-Entourage/12.20.0.090605
On 19/10/2009 12:43, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

>> I retest version with removed NULL checks and in this case, my system
>> crashes.
>> So there has to be checks for NULL or something else is wrong.
> 
> Got a backtrace and Xen boot params? If you pass acpi=off, then
> disable_acpi() is invoked, and this sets acpi_disabled. If acpi_disabled=1,
> then iommu_setup() sets iommu_enabled=0. If iommu_enabled=0 then I think all
> the update_ire_from_* and similar hooks get disabled in the callers. So
> something unexpected must be happening.

Hmmm, perhaps this could be an early boot-time crash before iommu_setup() is
even called? Perhaps moving the if(acpi_disabled) iommu_enabled=0 somewhere
early-ish in setup.c:__start_xen(), with a warning message, would be the
right thing to do in that case (e.g., immediately after the call to
cmdline_parse()).

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>