WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] RE: [Xen-changelog] [xen-unstable] vt-d: Fixpanic in msi_msg

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Miroslav Rezanina <mrezanin@xxxxxxxxxx>
Subject: [Xen-devel] RE: [Xen-changelog] [xen-unstable] vt-d: Fixpanic in msi_msg_read_remap_rte with acpi=off
From: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Date: Fri, 16 Oct 2009 18:36:42 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc:
Delivery-date: Fri, 16 Oct 2009 03:37:01 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C6FE07E9.179D8%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <EADF0A36011179459010BDF5142A457501CEC495EB@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C6FE07E9.179D8%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcpOOC2WMZHP9rJXSpWM9ZQfxjJ27QACxX5AAAHRae4AAEgZIA==
Thread-topic: [Xen-changelog] [xen-unstable] vt-d: Fixpanic in msi_msg_read_remap_rte with acpi=off
A better fix is:
At the begnning of in iommu_setup(), if acpi_pci_disabled, we set iommu_enabled 
to 0.

Thanks,
-- Dexuan



-----Original Message-----
From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx] 
Sent: 2009?10?16? 18:22
To: Cui, Dexuan; xen-devel@xxxxxxxxxxxxxxxxxxx; Miroslav Rezanina
Subject: Re: [Xen-changelog] [xen-unstable] vt-d: Fixpanic in 
msi_msg_read_remap_rte with acpi=off

On 16/10/2009 11:03, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> wrote:

> Actually when iommu=1 and acpi=off, in __start_xen() -> acpi_boot_init(),
> acpi_dmar_init() can't be invoked at all and hence parse_dmar_table() can't be
> invoked, as a result, we should not try to use VT-d at all, however, the
> global variable iommu_enabled is left set to 1.
> 
> So I don't think this changeset is the right fix. I think the correct one
> should be: in disable_acpi(), we force iommu_enabled to 0.

Sounds better to me.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel