[Xen-devel] RE: [Xen-changelog] [xen-unstable] vt-d: Fixpanic in msi_msg_read_remap_rte with acpi=off

["Cui, Dexuan" <dexuan.cui@xxxxxxxxx>]

A better fix is:
At the begnning of in iommu_setup(), if acpi_pci_disabled, we set iommu_enabled 
to 0.

Thanks,
-- Dexuan



-----Original Message-----
From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx] 
Sent: 2009?10?16? 18:22
To: Cui, Dexuan; xen-devel@xxxxxxxxxxxxxxxxxxx; Miroslav Rezanina
Subject: Re: [Xen-changelog] [xen-unstable] vt-d: Fixpanic in 
msi_msg_read_remap_rte with acpi=off

On 16/10/2009 11:03, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> wrote:

> Actually when iommu=1 and acpi=off, in __start_xen() -> acpi_boot_init(),
> acpi_dmar_init() can't be invoked at all and hence parse_dmar_table() can't be
> invoked, as a result, we should not try to use VT-d at all, however, the
> global variable iommu_enabled is left set to 1.
> 
> So I don't think this changeset is the right fix. I think the correct one
> should be: in disable_acpi(), we force iommu_enabled to 0.

Sounds better to me.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel