WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [GIT PULL RFC] pvclock cleanups and pvclock vsyscall sup

To: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
Subject: [Xen-devel] Re: [GIT PULL RFC] pvclock cleanups and pvclock vsyscall support
From: Avi Kivity <avi@xxxxxxxxxx>
Date: Thu, 15 Oct 2009 15:51:37 +0900
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, kurt.hackel@xxxxxxxxxx, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Glauber de Oliveira Costa <gcosta@xxxxxxxxxx>, Chris Mason <chris.mason@xxxxxxxxxx>
Delivery-date: Wed, 14 Oct 2009 23:53:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1255548516-15260-1-git-send-email-jeremy.fitzhardinge@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1255548516-15260-1-git-send-email-jeremy.fitzhardinge@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Thunderbird/3.0b3
On 10/15/2009 04:28 AM, Jeremy Fitzhardinge wrote:
Hi all,

This series contains several things:

  - Unify the separate vdso and vsyscall implementations of vgettimeofday and
    vgetcpu.  There's at least one bugfix which was only applied to one copy
    (ignore tcache in vgetcpu was only applied to the vdso version); this
    should avoid such skews in future.

  - Bug fixes for the Xen and KVM clocksource.read functions to make sure
    the returned time doesn't regress compared to clocksource.cycle_last.
    (Probably stable material.)

  - Make sure the pvclock rdtsc is surrounded by appropriate barriers so
    that it doesn't get speculated to the wrong place with respect to reading
    the time parameters.  (Probably stable material.)

  - General cleanups of the pvclock algorithm (there's no need to make a local
    copy of the time parameters before use).

  - Add a new CONFIG_X86_VSYSCALL to control the compilation of vsyscall-related
    code rather than just using CONFIG_X86_64 - we may want to implement 32-bit
    vsyscall at some point, and this will make it easier.

  - Add the sched notifier for task migration between CPUs, for use by
    pvclock vread.

  - Implement a pvclock vread function, so that pvclock-using clocksources can 
be
    used by vsyscall/vdso vgettimeofday and vclock_gettime.

  - Use pvclock vread in the Xen clocksource.

Looks good to me.

Acked-by etc.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>